Skip to content

Conversation

@NathanFlurry
Copy link
Member

Changes

Copy link
Member Author

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more


How to use the Graphite Merge Queue

Add the label merge-queue to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@graphite-app
Copy link
Contributor

graphite-app bot commented Feb 8, 2025

Merge activity

  • Feb 7, 8:03 PM EST: A user added this pull request to the Graphite merge queue.
  • Feb 7, 8:04 PM EST: CI is running for this PR on a draft PR: #2007
  • Feb 7, 8:05 PM EST: A user merged this pull request with the Graphite merge queue via draft PR: #2007.

Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

This PR simplifies the setup documentation by transitioning from Deno to Node.js-based tooling and modernizing SDK instructions for better developer experience.

  • Removed Deno runtime dependency in favor of tsx for running tests in /site/src/content/docs/setup.mdx
  • Added package manager-specific installation instructions (npm, pnpm, yarn, bun) for @rivet-gg/actor-client
  • Streamlined introduction and removed redundant editor/IDE setup section
  • Potential issue: May need additional setup instructions for tsx command compatibility

1 file(s) reviewed, 2 comment(s)
Edit PR Review Bot Settings | Greptile

After initializing your project, now you will deploy your actor to Rivet's servers.

Run the following command, and replace `my-app` with the name of your project:
After initializing your project, will deploy your actor to Rivet's servers:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

syntax: Grammar error in this sentence - 'will deploy' should be 'we will deploy' or 'you will deploy'

Suggested change
After initializing your project, will deploy your actor to Rivet's servers:
After initializing your project, you will deploy your actor to Rivet's servers:


```sh
rivet deno run -A counter_test.ts
npx tsx counter_test.ts
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

logic: Missing prerequisite instructions for installing tsx and setting up Node.js environment before running this command

graphite-app bot pushed a commit that referenced this pull request Feb 8, 2025
<!-- Please make sure there is an issue that this PR is correlated to. -->

## Changes

<!-- If there are frontend changes, please include screenshots. -->
@graphite-app graphite-app bot deleted the branch 02-07-fix_cli_auto-generate_.yarnrc.yml_to_disable_pnp_for_tsx_support February 8, 2025 01:05
@graphite-app graphite-app bot closed this Feb 8, 2025
@graphite-app graphite-app bot closed this Feb 8, 2025
@graphite-app graphite-app bot deleted the docs_simplify_setup_guide_and_modernize_SDK_instructions branch February 8, 2025 01:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants